Do not use JSON for internal routing #870
Conversation
JSON encoding/decoding is very CPU intensive. Use character separated string for internal routing representation.
|
Canceling Rust GH actions because that changes are missing. |
jmillan
force-pushed
the
jmillan/do-not-use-json-for-internal-routing
branch
from
5c81f48
to
6358399
Compare
| @@ -197,4 +200,16 @@ namespace Channel | |||
|
|
|||
| this->channel->Send(jsonResponse); | |||
| } | |||
|
|
|||
| const std::string& ChannelRequest::GetNextInternalRoutingId() | |||
There was a problem hiding this comment.
Perhaps "Pop" instead of "Get"? A method called "GetXxxx()" should not modify internal state and should be idempotent. "Pop" instead means remove and give me the last item.
There was a problem hiding this comment.
We are not doing pop. We maintain an internal nextRoutingLevel member that we increase everytime this function is called.
Yes, "GetXxx" should generally not modify the state.
There was a problem hiding this comment.
initially we commented about keeping the routing IDs within a std::queue, and pop() as we get the next id. But after implementation it seemed more convoluted than re-using the original std::vector returned from splitting the message, plus this way we can avoid creating a string instance for every call to the function.
|
What you think about replacing json by protobuf? This way we can save CPU/RAM and generate types for typescript/c++/rust. |
|
We are completely removing any data structure for Data structures for |
- Replaces PR #870. ### TODO - There are two TODO comments in CPP files regarding PPID parsing/conversion. We should catch those errors and throw with `MS_THROW_TYPE_ERROR()` instead, otherwise the process will crash since we just expect `MediaSoupErrors`. - Rust layer.
|
Closing in favor of #893 |
JSON encoding/decoding is very CPU intensive.
Use character separated string for
internalrouting representation.datainfo from node to worker forChannelremains being JSON.datainfo from node to worker forPayloadChannelis a now string to be decoded by the target:data, and we are NOT sending it as JSON but as plain string.