Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RtpStreamSend: Do not store too old RTP packets #885

Merged
merged 3 commits into from
Jul 28, 2022
Merged

RtpStreamSend: Do not store too old RTP packets #885

merged 3 commits into from
Jul 28, 2022

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Jul 28, 2022

Fixes #882

@jmillan jmillan requested review from ibc and nazar-pc July 28, 2022 11:14
@jmillan
Copy link
Member Author

jmillan commented Jul 28, 2022

Fuzzer would detect the crash right away, after the change it runs for long minutes without issues.

nazar-pc
nazar-pc approved these changes Jul 28, 2022
View reviewed changes
Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, bug was tricky, glad that we have fuzzer

@jmillan
Copy link
Member Author

jmillan commented Jul 28, 2022

I'm merging and releasing a new version

@jmillan jmillan merged commit 10cfd3a into v3 Jul 28, 2022
@jmillan jmillan deleted the issue_882 branch July 28, 2022 13:50
@nazar-pc
Copy link
Collaborator

nazar-pc commented Jul 28, 2022 •
edited
Loading

Can you bump mediasoup-sys patch version so I can publish Rust release too?

@jmillan
Copy link
Member Author

jmillan commented Jul 28, 2022

Can you bump mediasoup-sys patch version so I can publish Rust release too?

It's only about the version field in Cargo.toml, right?

@nazar-pc
Copy link
Collaborator

Yes, just patch version in worker/Cargo.toml

ibc
ibc reviewed Aug 1, 2022
View reviewed changes
Copy link
Member

@ibc ibc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add in CHANGELOG

@jmillan
Copy link
Member Author

jmillan commented Aug 1, 2022

You are very right, I missed that and I already released..

@jmillan
Copy link
Member Author

jmillan commented Aug 1, 2022

Done

piranna pushed a commit to dyte-in/mediasoup that referenced this pull request Feb 9, 2023
@jmillan @piranna
RtpStreamSend: Do not store too old RTP packets (versatica#885)
4f2caff 
RtpStreamSend: Do not store too old RTP packets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc ibc left review comments

@nazar-pc nazar-pc nazar-pc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash at assertion 'StorageItemBuffer contains more than 65535 entries'
3 participants
@jmillan @nazar-pc @ibc