New ChannelMessageHandlers class (fixes issue #892)

[ibc]

• Fixes Leak in Worker::mapChannelRequestHandlers and other maps #892
• Bonus track: fixes make fuzzer no longer works (missing target in meson.build) #895

Details

Introduce a new ChannelMessageHandlers in worker that handles the Channel and PayloadChannel request/notification handlers.

Entities that wish to receive requests/notifications from Node/Rust must register themselves in their class constructor and unregister in their destructors.

class ChannelMessageHandlers
{
public:
	static void RegisterHandler(
	  const std::string& id,
	  Channel::ChannelSocket::RequestHandler* channelRequestHandler,
	  PayloadChannel::PayloadChannelSocket::RequestHandler* payloadChannelRequestHandler,
	  PayloadChannel::PayloadChannelSocket::NotificationHandler* payloadChannelNotificationHandler);
	static void UnregisterHandler(const std::string& id);

The RegisterHandler() function is smart and unregisters the entity from all maps in case its id was already present in any of them.

TODO

• Adapt tests in Rust so they take into account the new channelRequestHandlers object field in the Worker dump output (I was not able to figure out how to compare the new obtained objects in Rust land).

[ibc]

@jmillan @nazar-pc this is ready for review. Unfortunately I need it merged today :(

[nazar-pc]

Makes sense to me, though I'm not a big fan of introduction of even more global data structures.

[ibc]

Makes sense to me, though I'm not a big fan of introduction of even more global data structures.

I would like to avoid those static maps and use a class instance instead, but that requires much more work and huge changes everywhere. But I'll think about it and will try to change it in the future. I won't forget.

[ibc]

@nazar-pc approved? XD

[nazar-pc]

With a heavy ❤️ (sorry 🦀, I'll fix you, I promise)

[jmillan]

👍