Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RtpPacket: optimize UpdateMid() #920

Merged
merged 1 commit into from
Sep 30, 2022
Merged

RtpPacket: optimize UpdateMid() #920

merged 1 commit into from
Sep 30, 2022

Conversation

jmillan
Copy link
Member

@jmillan jmillan commented Sep 30, 2022

  • Make it void since the return value is not used anywhere.
  • Cache the mid string size to avoid calling it multiple times.

@jmillan
RtpPacket: optimize UpdateMid()
66702be 
* Make it void since the return value is not used anywhere.
* Cache the mid string size to avoid calling it multiple times.
@jmillan jmillan requested a review from ibc September 30, 2022 09:33
@jmillan jmillan merged commit 9aef3f5 into v3 Sep 30, 2022
@jmillan jmillan deleted the rtppacket-optimize-updatemid branch September 30, 2022 12:53
piranna pushed a commit to dyte-in/mediasoup that referenced this pull request Feb 9, 2023
@jmillan @piranna
RtpPacket: optimize UpdateMid() (versatica#920)
7f423ca 
* Make it void since the return value is not used anywhere.
* Cache the mid string size to avoid calling it multiple times.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibc ibc ibc approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmillan @ibc