SctpAssociation: fix memory violation #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...when sctp debug tag is set, for SCTP_ASSOC_CHANGE notification. Closes #904 We were taking the 'sn_assoc_change.sac_info' length wrongly, unlike for the other notifications we are logging. - usrsctp code where the notification is created: https://github.com/sctplab/usrsctp/blob/master/usrsctplib/netinet/sctputil.c#L3296 - Example code where this length is retrieved correctly: https://github.com/sctplab/usrsctp/blob/master/programs/rtcweb.c#L871
Closed
ibc
approved these changes
Nov 4, 2022
|
Please, changes in CHANGELOG |
|
Conflicts :) |
ibc
reviewed
Nov 4, 2022
ibc
approved these changes
Nov 4, 2022
piranna
pushed a commit
to dyte-in/mediasoup
that referenced
this pull request
Feb 9, 2023
* SctpAssociation: fix memory violation ...when sctp debug tag is set, for SCTP_ASSOC_CHANGE notification. Closes versatica#904 We were taking the 'sn_assoc_change.sac_info' length wrongly, unlike for the other notifications we are logging. - usrsctp code where the notification is created: https://github.com/sctplab/usrsctp/blob/master/usrsctplib/netinet/sctputil.c#L3296 - Example code where this length is retrieved correctly: https://github.com/sctplab/usrsctp/blob/master/programs/rtcweb.c#L871 * Update CHANGELOG * normalize CHANGELOG * be consistent with struct size retrieval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...when sctp debug tag is set, for SCTP_ASSOC_CHANGE notification.
Closes #904
We were taking the 'sn_assoc_change.sac_info' length wrongly, unlike for the other notifications we are logging.
usrsctp code where the notification is created: https://github.com/sctplab/usrsctp/blob/master/usrsctplib/netinet/sctputil.c#L3296
Example code where this length is retrieved correctly: https://github.com/sctplab/usrsctp/blob/master/programs/rtcweb.c#L871