Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meson: Pin ninja version to 1.10.2.4 #948

Merged
merged 3 commits into from
Nov 5, 2022
Merged

Conversation

ibc
Copy link
Member

@ibc ibc commented Nov 5, 2022

  • Avoid issue in Linux using ninja latest version 1.11.1 which returns error code 245 instead of 0 when running ninja --version, which makes Meson fail.
  • Thanks Vittorio Palmisano @vpalmisano.

More info:

- Avoid segfault in Linux using `ninja` latest version 1.11.1.
- Thanks Vittorio Palmisano @vpalmisano.

More info:

- https://mediasoup.discourse.group/t/partly-solved-could-not-detect-ninja-v1-8-2-or-newer
- ninja-build/ninja#2211
@ibc ibc requested a review from nazar-pc November 5, 2022 20:30
Copy link
Collaborator

@nazar-pc nazar-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Meson chat:

it's because ninja returns "1.11.1.git.kitware.jobserver-1" for "ninja --version" and meson fails to parse that

worker/Makefile Outdated Show resolved Hide resolved
@ibc ibc merged commit 2470667 into v3 Nov 5, 2022
@ibc ibc deleted the pin-ninja-version-to-1.10.2.4 branch November 5, 2022 20:38
@ibc
Copy link
Member Author

ibc commented Nov 5, 2022

Released in mediasoup node 3.11.2.

@nazar-pc I assume a mediasoup Rust version is also required.

@nazar-pc
Copy link
Collaborator

nazar-pc commented Nov 5, 2022

Upstream issue: scikit-build/ninja-python-distributions#157
Looks like in the end basic commands return non-zero status code 🙃

@ibc
Copy link
Member Author

ibc commented Nov 5, 2022

Yup.

@henryiii
Copy link

henryiii commented Nov 6, 2022

Could you retry? I think ninja may no longer support manylinux1 (centos 5).

@henryiii
Copy link

henryiii commented Nov 6, 2022

This is fixed, I believe. manylinux2010 images are working elsewhere. The manylinux1 images might get removed at some point, but they actually do work on manylinux1 I believe (since cibuildwheel's tests passed). I've also been able to reproduce the failure and the fix in CI tests.

Also, please do not pin if there's a broken release & it's not an intentional breakage; instead just block out that release (!=1.11.1 in this case). However, in this case, 1.11.1 itself was fixed, since it was not a code problem.

@nazar-pc
Copy link
Collaborator

nazar-pc commented Nov 6, 2022

Thanks @henryiii, we've just being overly cautious by pinning to last known good version.

piranna pushed a commit to dyte-in/mediasoup that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants