-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meson: Pin ninja version to 1.10.2.4 #948
Conversation
- Avoid segfault in Linux using `ninja` latest version 1.11.1. - Thanks Vittorio Palmisano @vpalmisano. More info: - https://mediasoup.discourse.group/t/partly-solved-could-not-detect-ninja-v1-8-2-or-newer - ninja-build/ninja#2211
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Meson chat:
it's because ninja returns "1.11.1.git.kitware.jobserver-1" for "ninja --version" and meson fails to parse that
Released in mediasoup node 3.11.2. @nazar-pc I assume a mediasoup Rust version is also required. |
Upstream issue: scikit-build/ninja-python-distributions#157 |
Yup. |
Could you retry? I think ninja may no longer support manylinux1 (centos 5). |
This is fixed, I believe. manylinux2010 images are working elsewhere. The manylinux1 images might get removed at some point, but they actually do work on manylinux1 I believe (since cibuildwheel's tests passed). I've also been able to reproduce the failure and the fix in CI tests. Also, please do not pin if there's a broken release & it's not an intentional breakage; instead just block out that release ( |
Thanks @henryiii, we've just being overly cautious by pinning to last known good version. |
ninja
latest version 1.11.1 which returns error code 245 instead of 0 when runningninja --version
, which makes Meson fail.More info:
ninja --version
returns a nonzero error code in a shell on Linux. ninja-build/ninja#2212