ChannelMessageHandlers: Make RegisterHandler() not remove the existing handler if another one with same id is given #952

Add a test to assert than calling `router1.pipeToRouter(router2)` fails if both `Routers` are in the same `Worker`. ### TODO The new test succeed however it **breaks** an unrelated test that runs later that should NOT be affected at all: ``` FAIL node/tests/test-PipeTransport.js ✓ router.pipeToRouter() succeeds with audio (24 ms) ✓ router.pipeToRouter() succeeds with video (21 ms) ### NEW TEST: ✓ router.pipeToRouter() fails if both Routers belong to the same Worker (32 ms) ✓ router.createPipeTransport() with enableRtx succeeds (6 ms) ✓ router.createPipeTransport() with invalid srtpParameters must fail (3 ms) ✓ router.createPipeTransport() with enableSrtp succeeds (9 ms) ✓ router.createPipeTransport() with fixed port succeeds (8 ms) ✓ transport.consume() for a pipe Producer succeeds (6 ms) ### UNRELATED FAILING TEST: ✕ producer.pause() and producer.resume() are transmitted to pipe Consumer (2 ms) ✓ producer.close() is transmitted to pipe Consumer (2 ms) ✓ router.pipeToRouter() succeeds with data (7 ms) ✓ transport.dataConsume() for a pipe DataProducer succeeds (2 ms) ✓ dataProducer.close() is transmitted to pipe DataConsumer (2 ms) ✓ router.pipeToRouter() called twice generates a single PipeTransport pair (14 ms) ✓ router.pipeToRouter() called in two Routers passing one to each other as argument generates a single a single PipeTransport pair (10 ms) ● producer.pause() and producer.resume() are transmitted to pipe Consumer Channel request handler with ID c9cba815-1128-4500-aa4f-7edbc135b889 not found [method:producer.resume] ``` It doesn't make sense that such a test fails with that error (producer not found in the worker). To simplify the error, I've added a temporal code in the new test that clearly shows the issue: ```ts test('router.pipeToRouter() fails if both Routers belong to the same Worker', async () => { const router1bis = await worker1.createRouter({ mediaCodecs }); await expect(router1.pipeToRouter( { producerId : videoProducer.id, router : router1bis })) .rejects .toThrow(Error); // TODO: Temporal code to show an unexpected error. { // This is ok. expect(videoProducer.closed).toBe(false); // However these will fail since the handler Id does not exist in the worker. // This is impossible and must be a bug. await videoProducer.resume(); await videoProducer.pause(); } router1bis.close(); }, 2000); ``` In addition, Rust test is missing but I don't want to deal with that until the issue is solved.

… handler id another one with same id is given

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ChannelMessageHandlers: Make RegisterHandler() not remove the existing handler if another one with same id is given #952

ChannelMessageHandlers: Make RegisterHandler() not remove the existing handler if another one with same id is given #952

Commits on Nov 6, 2022