Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: Remove compiled JavaScript from repository and compile TypeScript code on NPM prepare script on demand when installed via git #954

Merged
merged 36 commits into from
Nov 18, 2022
Merged
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
cd6099e
Node: Compile TypeScript code on postinstall
ibc Nov 11, 2022
36ebdd3
Really remove /node/lib/
ibc Nov 11, 2022
6e0c4f2
Make Windows happy
ibc Nov 11, 2022
fbfd970
.gitignore: cosmetic
ibc Nov 11, 2022
896fea1
Update CHANGELOG.md
ibc Nov 11, 2022
912d4d9
fix npm-scripts.js
ibc Nov 11, 2022
cdef1a9
npm-scripts.js: fix lint
ibc Nov 11, 2022
535e8e9
Update files in package.json
ibc Nov 15, 2022
60a7d55
package.json: include node/tsconfig.json in files
ibc Nov 15, 2022
32dc5b6
Merge branch 'v3' into compile-typescript-in-npm-postinstall
ibc Nov 15, 2022
922883a
package.json: move dependencies defining TS types from devDependencie…
ibc Nov 15, 2022
dc112b1
Merge branch 'v3' into compile-typescript-in-npm-postinstall
ibc Nov 15, 2022
3077769
npm-scripts.js: Make 'test:node' task compile TS to JS
ibc Nov 15, 2022
5dccfbb
Merge branch 'v3' into compile-typescript-in-npm-postinstall
ibc Nov 15, 2022
7e62ea2
Merge branch 'v3' into compile-typescript-in-npm-postinstall
ibc Nov 15, 2022
5b0ecc1
Merge branch 'v3' into compile-typescript-in-npm-postinstall
ibc Nov 17, 2022
af81f3a
- Add package-lock.json.
ibc Nov 17, 2022
38789bf
Update CHANGELOG
ibc Nov 17, 2022
5dd182c
Uninstall typescript libs after building
ibc Nov 17, 2022
a44253a
Add --no-save
ibc Nov 17, 2022
a2cafbe
Add prepack NPM script
ibc Nov 17, 2022
d9251b0
test a thing
ibc Nov 17, 2022
18b1e14
test 2
ibc Nov 17, 2022
2f7001d
revert tests
ibc Nov 17, 2022
f6a37ba
postinstall
ibc Nov 17, 2022
c60508a
improvements
ibc Nov 17, 2022
9a4b45a
cosmetic
ibc Nov 17, 2022
591399c
fix .github/workflows/mediasoup-node.yaml
ibc Nov 17, 2022
79b9baa
Use prepare instead of prepack
ibc Nov 17, 2022
95fa080
Improve npm-scripts.js by adding functions
ibc Nov 17, 2022
bfd6560
Make npm-scripts.js better
ibc Nov 18, 2022
18b7b27
Improve copy
ibc Nov 18, 2022
a962fde
Address feedback:
ibc Nov 18, 2022
f291104
fix lint
ibc Nov 18, 2022
1e457ea
Address feedback 2
ibc Nov 18, 2022
7eb25a7
cosmetic
ibc Nov 18, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Tell GitHub to ignore some folders when detecting the project language.
art/* linguist-vendored=true
doc/* linguist-vendored=true
node/lib/* linguist-vendored=true
node/test/* linguist-vendored=true
rust/benches/* linguist-vendored=true
rust/examples/* linguist-vendored=true
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/mediasoup-node.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,4 @@ jobs:
- run: npm install
- run: npm run lint:node
if: runner.os == 'Linux'
- run: npm run typescript:build
- run: npm run test:node
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

## Node.
/node_modules/
/node/lib/

## Rust.
/Cargo.lock
Expand Down
5 changes: 4 additions & 1 deletion .npmrc
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
package-lock=false
# Generate package-lock.json.
package-lock=true
# For bad node/npm version to throw actual error.
engine-strict=true
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

### NEXT

* Node: Remove compiled JavaScript from repository and compile TypeScript code on NPM `prepare` script on demand when installed via git (PR #954).
* `Worker`: Add `RTC::Shared` singleton for RTC entities (PR #953).


Expand Down
36 changes: 0 additions & 36 deletions node/lib/ActiveSpeakerObserver.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion node/lib/ActiveSpeakerObserver.d.ts.map

This file was deleted.

44 changes: 0 additions & 44 deletions node/lib/ActiveSpeakerObserver.js

This file was deleted.

55 changes: 0 additions & 55 deletions node/lib/AudioLevelObserver.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion node/lib/AudioLevelObserver.d.ts.map

This file was deleted.

56 changes: 0 additions & 56 deletions node/lib/AudioLevelObserver.js

This file was deleted.

22 changes: 0 additions & 22 deletions node/lib/Channel.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion node/lib/Channel.d.ts.map

This file was deleted.

Loading