Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Node tests to TypeScript #958

Merged
merged 4 commits into from
Nov 21, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
# Tell GitHub to ignore some folders when detecting the project language.
art/* linguist-vendored=true
doc/* linguist-vendored=true
node/test/* linguist-vendored=true
rust/benches/* linguist-vendored=true
rust/examples/* linguist-vendored=true
rust/examples-frontend/* linguist-vendored=true
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

## Others.
/coverage
/.cache
/NO_GIT
*.swp
*.swo
Expand Down
5 changes: 3 additions & 2 deletions node/.eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ const eslintConfig =
{
impliedStrict : true
},
lib : [ 'es2018' ]
lib : [ 'es2018' ],
project : 'node/tsconfig.json'
},
globals :
{
Expand Down Expand Up @@ -222,7 +223,7 @@ eslintConfig.overrides.push(

eslintConfig.overrides.push(
{
files : [ '*.js' ],
files : [ '*.ts' ],
env : {
...eslintConfig.env,
'jest/globals' : true
Expand Down
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
const { toBeType } = require('jest-tobetype');
const mediasoup = require('../lib/');
const { createWorker } = mediasoup;
import * as mediasoup from '../';

expect.extend({ toBeType });
const { createWorker } = mediasoup;

let worker;
let router;
let activeSpeakerObserver;
let worker: mediasoup.types.Worker;
let router: mediasoup.types.Router;
let activeSpeakerObserver: mediasoup.types.ActiveSpeakerObserver;

const mediaCodecs =
const mediaCodecs: mediasoup.types.RtpCodecCapability[] =
[
{
kind : 'audio',
Expand Down Expand Up @@ -41,7 +39,7 @@ test('router.createActiveSpeakerObserver() succeeds', async () =>

expect(onObserverNewRtpObserver).toHaveBeenCalledTimes(1);
expect(onObserverNewRtpObserver).toHaveBeenCalledWith(activeSpeakerObserver);
expect(activeSpeakerObserver.id).toBeType('string');
expect(typeof activeSpeakerObserver.id).toBe('string');
expect(activeSpeakerObserver.closed).toBe(false);
expect(activeSpeakerObserver.paused).toBe(false);
expect(activeSpeakerObserver.appData).toEqual({});
Expand All @@ -56,10 +54,12 @@ test('router.createActiveSpeakerObserver() succeeds', async () =>

test('router.createActiveSpeakerObserver() with wrong arguments rejects with TypeError', async () =>
{
// @ts-ignore
await expect(router.createActiveSpeakerObserver({ interval: false }))
.rejects
.toThrow(TypeError);

// @ts-ignore
await expect(router.createActiveSpeakerObserver({ appData: 'NOT-AN-OBJECT' }))
.rejects
.toThrow(TypeError);
Expand Down Expand Up @@ -102,7 +102,7 @@ test('ActiveSpeakerObserver emits "routerclose" if Router is closed', async () =
const router2 = await worker.createRouter({ mediaCodecs });
const activeSpeakerObserver2 = await router2.createAudioLevelObserver();

await new Promise((resolve) =>
await new Promise<void>((resolve) =>
{
activeSpeakerObserver2.on('routerclose', resolve);
router2.close();
Expand All @@ -113,7 +113,7 @@ test('ActiveSpeakerObserver emits "routerclose" if Router is closed', async () =

test('ActiveSpeakerObserver emits "routerclose" if Worker is closed', async () =>
{
await new Promise((resolve) =>
await new Promise<void>((resolve) =>
{
activeSpeakerObserver.on('routerclose', resolve);
worker.close();
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
const { toBeType } = require('jest-tobetype');
const mediasoup = require('../lib/');
import * as mediasoup from '../';
const { createWorker } = mediasoup;

expect.extend({ toBeType });
let worker: mediasoup.types.Worker;
let router: mediasoup.types.Router;
let audioLevelObserver: mediasoup.types.AudioLevelObserver;

let worker;
let router;
let audioLevelObserver;

const mediaCodecs =
const mediaCodecs: mediasoup.types.RtpCodecCapability[] =
[
{
kind : 'audio',
Expand Down Expand Up @@ -41,7 +38,7 @@ test('router.createAudioLevelObserver() succeeds', async () =>

expect(onObserverNewRtpObserver).toHaveBeenCalledTimes(1);
expect(onObserverNewRtpObserver).toHaveBeenCalledWith(audioLevelObserver);
expect(audioLevelObserver.id).toBeType('string');
expect(typeof audioLevelObserver.id).toBe('string');
expect(audioLevelObserver.closed).toBe(false);
expect(audioLevelObserver.paused).toBe(false);
expect(audioLevelObserver.appData).toEqual({});
Expand All @@ -64,14 +61,17 @@ test('router.createAudioLevelObserver() with wrong arguments rejects with TypeEr
.rejects
.toThrow(TypeError);

// @ts-ignore
await expect(router.createAudioLevelObserver({ threshold: 'foo' }))
.rejects
.toThrow(TypeError);

// @ts-ignore
await expect(router.createAudioLevelObserver({ interval: false }))
.rejects
.toThrow(TypeError);

// @ts-ignore
await expect(router.createAudioLevelObserver({ appData: 'NOT-AN-OBJECT' }))
.rejects
.toThrow(TypeError);
Expand Down Expand Up @@ -114,7 +114,7 @@ test('AudioLevelObserver emits "routerclose" if Router is closed', async () =>
const router2 = await worker.createRouter({ mediaCodecs });
const audioLevelObserver2 = await router2.createAudioLevelObserver();

await new Promise((resolve) =>
await new Promise<void>((resolve) =>
{
audioLevelObserver2.on('routerclose', resolve);
router2.close();
Expand All @@ -125,7 +125,7 @@ test('AudioLevelObserver emits "routerclose" if Router is closed', async () =>

test('AudioLevelObserver emits "routerclose" if Worker is closed', async () =>
{
await new Promise((resolve) =>
await new Promise<void>((resolve) =>
{
audioLevelObserver.on('routerclose', resolve);
worker.close();
Expand Down
Loading