-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support richtext in editor #3
base: main
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/verses-xyz/pluriverse/6DX5LQLgYfdaNFYFgTZ1ZDQhoVuK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work!! left some comments
onChange={onChange} | ||
placeholder={extraProps.placeholder ? extraProps.placeholder : null} | ||
/> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh also i added a maxLength on the text area in a recent change (you'll need to merge/rebase with main) and that would be good to incorporate here (900 characters)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh nice! just updated to support this using tiptap's character count
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
@queden is attempting to deploy a commit to the verses Team on Vercel. To accomplish this, @queden needs to request access to the Team. Afterwards, an owner of the Team is required to accept their membership request. If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account. |
onChange={onChange} | ||
placeholder={extraProps.placeholder ? extraProps.placeholder : null} | ||
/> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
className={`pageProgress ${ | ||
page === p ? "selectedPageProgress" : "" | ||
}`} | ||
className={`pageProgress ${page === p ? "selectedPageProgress" : "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you revert this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol not on my usual dev setup this week and some random vs code package did this my bad, in what world does this look good
browser/package.json
Outdated
"@tiptap/extension-paragraph": "^2.0.0-beta.23", | ||
"@tiptap/extension-placeholder": "^2.0.0-beta.46", | ||
"@tiptap/extension-text": "^2.0.0-beta.15", | ||
"@tiptap/extension-underline": "^2.0.0-beta.22", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you remove this / would do a pass and remove anything we don't need
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
@@ -147,45 +169,48 @@ export function ContributionCard({ | |||
<p className="author text-color-purple-200">{authorDisplay}</p> | |||
<p>{dateDisplay}</p> | |||
</p> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay i need to remove whatever prettify package is on this editor sorry lol
Terrible quality video of interface