Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config command #211

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Conversation

Chance-fyi
Copy link
Member

Idea from #204, this PR provides an alternative implementation.
It is implemented through reflection, so that you don't have to add a new config subcommand after adding a new config item.

cc @cifaz

@aooohan
Copy link
Member

aooohan commented Apr 17, 2024

I prefer this.

@cifaz
Copy link
Contributor

cifaz commented Apr 17, 2024

It's a better implementation. I like this.

Copy link
Member

@aooohan aooohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types currently supported are completely sufficient. If necessary later, we will expand on this.

docs/zh-hans/guides/configuration.md Outdated Show resolved Hide resolved
docs/guides/configuration.md Outdated Show resolved Hide resolved
@aooohan aooohan merged commit dd04e16 into version-fox:main Apr 18, 2024
aooohan pushed a commit to Chance-fyi/vfox that referenced this pull request Apr 18, 2024
Only string and boolean type are supported.


---------
Co-authored-by: Han Li <aooohan@gmail.com>
@Chance-fyi Chance-fyi deleted the feature/add-config-command branch May 7, 2024 03:32
@Chance-fyi Chance-fyi restored the feature/add-config-command branch May 7, 2024 03:33
@Chance-fyi Chance-fyi deleted the feature/add-config-command branch May 7, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants