Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix about adding plugin with alias #219

Merged
merged 3 commits into from
Apr 21, 2024
Merged

Fix about adding plugin with alias #219

merged 3 commits into from
Apr 21, 2024

Conversation

yanecc
Copy link
Contributor

@yanecc yanecc commented Apr 20, 2024

Fixes #218

@yanecc
Copy link
Contributor Author

yanecc commented Apr 21, 2024

Fixes #220

Copy link
Member

@aooohan aooohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This change, weakens the name of the plugin itself. It's based on the indexed repository and the alias name entered by the user. I think it's good.

@@ -384,22 +385,24 @@ func (m *Manager) downloadPlugin(downloadUrl string) (string, error) {
}

func (m *Manager) Add(pluginName, url, alias string) error {
// For compatibility with older versions of plugin names <category>/<plugin-name>
if strings.Contains(pluginName, "/") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is unlikely to be the case with custom plugins, it's harmless enough to keep.

@aooohan aooohan merged commit 7f0070c into version-fox:main Apr 21, 2024
aooohan added a commit that referenced this pull request Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Wrong behavior about plugin alias and something to be improved
2 participants