Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds support for symlink for plugins #351

Merged
merged 1 commit into from
Sep 21, 2024
Merged

fix: Adds support for symlink for plugins #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions internal/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"errors"
"fmt"
"io"
"io/fs"
"net"
"net/http"
"net/url"
Expand Down Expand Up @@ -159,6 +160,24 @@ func (m *Manager) LoadAllSdk() ([]*Sdk, error) {
for _, d := range dir {
sdkName := d.Name()
path := filepath.Join(m.PathMeta.PluginPath, sdkName)

// Resolve symbolic link, useful for plugin development
dirInfo, err := d.Info()
if err != nil {
return nil, fmt.Errorf("failed to get directory info: %w", err)
}
if dirInfo.Mode()&os.ModeSymlink != 0 {
resolvedPath, err := filepath.EvalSymlinks(path)
if err != nil {
return nil, fmt.Errorf("failed to resolve symboling link : %w", err)
}
dirFileInfo, err := os.Lstat(resolvedPath)
if err != nil {
return nil, fmt.Errorf("failed to get stat for resolved symbolic link : %w", err)
}
d = fs.FileInfoToDirEntry(dirFileInfo)
}

if d.IsDir() {
} else if strings.HasSuffix(sdkName, ".lua") {
logger.Debugf("Found old plugin: %s \n", path)
Expand Down