feat: add self-upgrade feature #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aooohan
reviewed
Jan 31, 2024
|
I have made the changes as mentioned by you. Pls review it. Thanks |
aooohan
reviewed
Jan 31, 2024
| return cli.Exit("Failed to extract file: "+err.Error(), 1) | ||
| } | ||
| newExePath := filepath.Join(tempDir, "vfox") | ||
| if err := os.Rename(newExePath, exePath); err != nil { |
There was a problem hiding this comment.
If you directly replace it, it should be possible under unix-like system, but is it also possible under windows? Will it not prompt that the current file(exePath) is occupied? The current process has not ended yet.
baymax55
reviewed
Feb 7, 2024
Comment on lines
+61
to
+71
| osType := strings.ToLower(runtime.GOOS) | ||
| if osType == "darwin" { | ||
| osType = "macos" | ||
| } | ||
|
|
||
| archType := runtime.GOARCH | ||
| if archType == "arm64" { | ||
| archType = "aarch64" | ||
| } | ||
|
|
||
| fileName := fmt.Sprintf("vfox_%s_%s_%s.tar.gz", tagName[1:], osType, archType) |
There was a problem hiding this comment.
Does it mean that Windows system self-update is not supported?
|
How is it going? May I help? |
|
Close in favor of #239 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature is added as described in issue #31 .