Run CLI as user 33:33 to match Debian's www-data #1388
Conversation
|
That looks good. Does that impact non-Linux OS's in some way? I'll try to run some tests on macOS shortly. |
|
I just added a commit to not do sudo, chown, and chgrp. That's all unnecessary since the tests already run as the right user. And doing those operations undoes the |
|
@candrews I'll go get some sleep but if you want me to run something tomorrow morning, let me know. I'm looking forward to seeing all tests pass again :) |
…hp7.2-apache versionpress/wordpress:php7.2-apache is based on wordpress:php7.2-apache which is based on debian. On Debian, www-data:www-data is 33:33 On Alpine (which is what cli is based on), www-data:www-data is 82:82 Therefore, when Alpine and Debian interact, one has to change to match the other. See docker-library/wordpress#256 for details
candrews
force-pushed
the
docker-cli-user
branch
from
ca7a1ca
to
89e3c50
Compare
|
With these changes, it's down to 19 errors and 16 skipped. So that's a nice improvement! @borekb can you please take a look? |
|
Thanks! |
|
Follow-up PR to this is #1397 which also sets the correct user for the mount points inside the Dockerfile. That resolves issues around test-logs and similar. |
borekb
changed the title
borekb
added
the
scope: dev-infrastructure
Issue: #1383
On Debian, www-data:www-data is 33:33
On Alpine (which is what cli is based on), www-data:www-data is 82:82
Therefore, when Alpine and Debian interact, one has to change to match the other.
See docker-library/wordpress#256 for details
Makes progress on #1383, Travis now gets further.