[Bug] - CopyObject fails with error "the specified bucket does not exist" if versitygw is configured with an IAM backend #773
Labels
bug
Something isn't working
Comments
|
cvubrugier
added a commit
to cvubrugier/versitygw
that referenced
this issue
Aug 29, 2024
The "x-amz-copy-source" header may start with '/' as observed with
WinSCP. However, '/' is also the separator between the bucket and the
object path in "x-amz-copy-source".
Consider the following code in VerifyObjectCopyAccess():
srcBucket, srcObject, found := strings.Cut(copySource, "/")
If `copySource` starts with '/', then `srcBucket` is set to an empty
string. Later, an error is returned because bucket "" does not exist.
This issue was fixed in the Posix and Azure backends by the following
commit:
* 5e484f2 fix: Fixed CopySource parsing to handle the values starting with '/' in CopyObject action in posix and azure backends.
But the issue was not fixed in `VerifyObjectCopyAccess`.
This commit sanitizes "x-amz-copy-source" right after the header is
extracted in `s3api/controllers/base.go`. This ensures that the
`CopySource` argument passed to the backend functions UploadPartCopy()
and CopyObject() does not start with '/'. Since the backends no longer
need to strip away any leading '/' in `CopySource`, the parts of
commit 5e484f2 modifying the Posix and Azure backends are reverted.
Fixes issue versity#773.
Signed-off-by: Christophe Vu-Brugier <christophe.vu-brugier@seagate.com>
|
fix PR merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
With WinSCP and Cyberduck, renaming or duplicating an object fails with error "the specified bucket does not exist" if versitygw is configured with an IAM backend.
To Reproduce
Expected behavior
The user should be able to rename or duplicate a file with WinSCP or Cyberduck.
Server and client versions
Bug analysis
To rename or duplicate an object, WinSCP and Cyberduck send a CopyObject S3 command that contains a
x-amz-copy-sourceheader that starts with '/'.The function VerifyObjectCopyAccess contains the following code:
If
copySourcestarts with '/', thensrcBucketis set to an empty string. Later, an error is returned because bucket "" does not exist.The same issue was fixed in the Posix and Azure backends by the following commit:
However, the issue still exist in
VerifyObjectCopyAccess.I will provide a fix for this issue.
The text was updated successfully, but these errors were encountered: