Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Try[X] instead of AsyncResult[X] #62

Closed
Narigo opened this issue Oct 15, 2013 · 3 comments
Closed

Use Try[X] instead of AsyncResult[X] #62

Narigo opened this issue Oct 15, 2013 · 3 comments
Assignees
@galderz
Milestone
1.0.0-RC1

Comments

@Narigo
Copy link
Member

Narigo commented Oct 15, 2013

Wouldn't it make sense to use scala.util.Try?
Then a user could pattern match over Success(result) and Failure(exception).
@Narigo
Copy link
Member Author

Narigo commented Oct 15, 2013

I've added an implicit Try to AsyncResult in #51 now. This should enable users to pattern match now. Guess that's a better approach as it won't get too far away from the official API to be able to write both.

@Narigo Narigo closed this as completed Oct 15, 2013
@Narigo
Copy link
Member Author

Narigo commented Oct 18, 2013

As said by @galderz in a [https://github.com//pull/63#discussion-diff-7033174 0.2.0 PR comment], we should explore this for 0.3.0

@Narigo Narigo reopened this Oct 18, 2013
@galderz
Copy link
Contributor

galderz commented Feb 12, 2014

Closing this, all async results should be converted to Future returns, so that they are completed with Success, and get a Failure otherwise. So, this really should be part of issue #16

@galderz galderz closed this as completed Feb 12, 2014
@galderz galderz self-assigned this Mar 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galderz galderz

Labels
None yet
Projects
None yet
Milestone
1.0.0-RC1
Development

No branches or pull requests
2 participants
@galderz @Narigo