Added exception Handler for Many to Many stream #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x01F4
changed the title
|
@vietj can you please have a look at this change? |
|
@tsegismont can you please have a look at this change? |
|
This project is deprecated, only security and critical bug fixes should be merged |
|
@tsegismont we will plan to move to https://github.com/eclipse-vertx/vertx-grpc. But in the mean time this issue is blocking us, can this accepted as critical fix? |
tsegismont
approved these changes
Nov 22, 2023
|
@giri-vsr can you please rebase your PR? There has been some fixes to the |
|
tsegismont
pushed a commit
that referenced
this pull request
Nov 23, 2023
|
Thank you @giri-vsr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
io.vertx.grpc.stub.ClientCalls.manyToManycalled if exception happens before returning the StreamObserverReadStream exception is lost.There is no way to register exceptionHandler before the call.We can register exceptionHandler only afterStreamObserverReadStreamreturn frommanyToMany.Fix for #141