Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: instrument vertx-web-openapi-router #254

Merged
merged 1 commit into from
Oct 20, 2023
Merged

feat: instrument vertx-web-openapi-router #254

merged 1 commit into from
Oct 20, 2023

Conversation

pk-work
Copy link
Contributor

@pk-work pk-work commented Oct 20, 2023

see #176

@pk-work pk-work requested a review from tsegismont October 20, 2023 11:12
tsegismont
tsegismont reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pk-work

Is vertx-web-openapi already present?

vertx-lang-kotlin/pom.xml
@@ -183,6 +183,11 @@
<artifactId>vertx-web-validation</artifactId>
<optional>true</optional>
</dependency>
<dependency>
<groupId>io.vertx</groupId>
<artifactId>vertx-web-openapi-router</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add the artifactId to the list in the maven dependency plugin config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@pk-work
Copy link
Contributor Author

pk-work commented Oct 20, 2023

Thanks @pk-work

Is vertx-web-openapi already present?

No, but this is good, because in Vert.x 5 it does not longer exist.

@pk-work pk-work requested a review from tsegismont October 20, 2023 13:45
tsegismont
tsegismont approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@tsegismont tsegismont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@pk-work pk-work merged commit d86d439 into master Oct 20, 2023
3 checks passed
@pk-work pk-work deleted the issue_176_v5 branch October 20, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsegismont tsegismont tsegismont approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pk-work @tsegismont