Add SSL support (rebase + tests) #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now can be used with Heroku, as heroku supports only SSL
Signed-off-by: Joern Bernhardt <jb@campudus.com>
Signed-off-by: Joern Bernhardt <jb@campudus.com>
Signed-off-by: Joern Bernhardt <jb@campudus.com>
Signed-off-by: Joern Bernhardt <jb@campudus.com>
|
Please review @Mart-Bogdan @pmlopes - thanks a lot @Mart-Bogdan for the initial PR and sorry that it took so long... |
Closed
Mart-Bogdan
approved these changes
Sep 13, 2017
ghost
mentioned this pull request
Closed
|
@Narigo what is missing for merging this PR ? |
|
awesome guys thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #78 and added tests.