-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cluster reconnect example #292
Fix cluster reconnect example #292
Conversation
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
…annotation Add a missing Nullable annotation
Initial support for pool metrics
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Azure redis hello command is broken, we need to avoid it
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Do not reuse connections that enter pubsub mode
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
…s empty Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Update RedisExamples.java to add onFailure in createRedisClient
…ions are in use Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
Signed-off-by: Paulo Lopes <pmlopes@gmail.com>
…' into fix-cluster-reconnect-example # Conflicts: # src/main/java/examples/RedisExamples.java
I've cherry picked the commit to |
@pmlopes @pendula95 I believe that the fixed version of the example will still suffer from a connection leak. The code attempts to call close() on RedisConnection, which (if I recall correctly) doesn't close the connection pool. You have to call close() on the Redis itself (the one returned from createClient) See #255 |
I think you are right. Looking at my own implementations in projects I see I use vertx-redis-client/src/main/java/io/vertx/redis/client/impl/RedisClusterConnection.java Line 522 in 3290a06
The example should be changed to feature this. |
Motivation: Current example shows bad practice that can lead to dangling connections and concurrent issues.
It should tackle the issue mentioned #255