Replace ISE with VertxException when failing context with informational message #2496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al message Related to vert-x3#2486 Follows-up on vert-x3#1857 ISE creates a stack trace which isn't really useful. In these cases, we only care about the message. This change makes the application log a single line (or more if the message is long). Besides, it saves the cost of creating the ISE stack trace. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
tsegismont
added a commit
that referenced
this pull request
Oct 25, 2023
…al message (#2496) Related to #2486 Follows-up on #1857 ISE creates a stack trace which isn't really useful. In these cases, we only care about the message. This change makes the application log a single line (or more if the message is long). Besides, it saves the cost of creating the ISE stack trace. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2486
Follows-up on #1857
ISE creates a stack trace which isn't really useful. In these cases, we only care about the message.
This change makes the application log a single line (or more if the message is long). Besides, it saves the cost of creating the ISE stack trace.
Motivation:
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines