Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catch all error handler #2633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

code-brazier
Copy link

Adding the feature described in #2632

@vietj
Copy link
Contributor

vietj commented Jul 16, 2024

@code-brazier can you instead name it "uncaughtErrorHandler"

@vietj vietj added this to the 5.0.0 milestone Jul 16, 2024
@tsegismont
Copy link
Contributor

@code-brazier thank you for proposing this.

Can you explain how this defers from:

router.route().failureHandler(myUncaughtFailureHandler)

@code-brazier
Copy link
Author

@tsegismont Router.errorHandler() and the proposed Router.uncaughtErrorHandler() are at a slightly higher level than Route.failureHandler()

Please correct this if it's not completely right, but basically the Router error handlers should catch any problems that occur before a Route handler (context or failure) is called, or if a Route handler throws an exception

Can I please ask if you know how I can get help creating an account with the eclipse foundation? I've emailed them to see what's happening with the account creation but haven't heard back from them. Thanks!

@tsegismont
Copy link
Contributor

Can I please ask if you know how I can get help creating an account with the eclipse foundation? I've emailed them to see what's happening with the account creation but haven't heard back from them. Thanks!

Let me check with them who can help you.

@code-brazier
Copy link
Author

I wasn't able to approve the email address I originally pushed with, so I have replaced my original commits with one from my approved email address. Is this ok or should I create a new branch?

@tsegismont
Copy link
Contributor

It's fine

@code-brazier
Copy link
Author

I've reapplied my commit and run the tests locally for vertx-web
[INFO] Tests run: 1035, Failures: 0, Errors: 0, Skipped: 0

Could I please request approval for the CI workflow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants