-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add catch all error handler #2633
base: master
Are you sure you want to change the base?
Conversation
@code-brazier can you instead name it "uncaughtErrorHandler" |
@code-brazier thank you for proposing this. Can you explain how this defers from: router.route().failureHandler(myUncaughtFailureHandler) |
@tsegismont Router.errorHandler() and the proposed Router.uncaughtErrorHandler() are at a slightly higher level than Route.failureHandler() Please correct this if it's not completely right, but basically the Router error handlers should catch any problems that occur before a Route handler (context or failure) is called, or if a Route handler throws an exception Can I please ask if you know how I can get help creating an account with the eclipse foundation? I've emailed them to see what's happening with the account creation but haven't heard back from them. Thanks! |
Let me check with them who can help you. |
803ad18
to
2491a2a
Compare
I wasn't able to approve the email address I originally pushed with, so I have replaced my original commits with one from my approved email address. Is this ok or should I create a new branch? |
It's fine |
c314fde
to
c64cab5
Compare
I've reapplied my commit and run the tests locally for vertx-web Could I please request approval for the CI workflow? |
Adding the feature described in #2632