Adds methods to update SSL Options to WebClient #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vietj
reviewed
Oct 20, 2024
vertx-web-client/src/main/java/io/vertx/ext/web/client/WebClient.java
Outdated
Show resolved
Hide resolved
vietj
reviewed
Oct 20, 2024
| * @param force force the update when options are equals | ||
| * @param handler the update handler | ||
| */ | ||
| default void updateSSLOptions(SSLOptions options, boolean force, Handler<AsyncResult<Boolean>> handler) { |
frankgh
force-pushed
the
add-update-ssl-options-to-webclient-master
branch
from
92f841b to
221d159
Compare
|
@frankgh can you rebase on latest master of vertx-web ? |
frankgh
force-pushed
the
add-update-ssl-options-to-webclient-master
branch
from
221d159 to
8fd8eab
Compare
This commit adds the ability to update the SSLOptions on the WebClient, similar to the methods in `io.vertx.core.http.HttpClient`. Internally, we delegate the calls to the underlying client.
frankgh
force-pushed
the
add-update-ssl-options-to-webclient-master
branch
from
8fd8eab to
a38f488
Compare
I was able to compile locally, I've fixed a few things, and CI should be green now. |
|
@frankgh thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to update the SSLOptions on the WebClient, similar to the methods in
io.vertx.core.http.HttpClient. Internally, we delegate the calls to the underlying client.Motivation:
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines