Revert RoutingContext#user() returning UserContext to User #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: RoutingContext#user() method returns the io.vertx.ext.auth.User interface in Vert.x 4.x, its return type has been change to UserContext instead (in addition of other changes), as UserContext is the preferred API for interacting with the user and the User interface actually represents the User. However, there is nothing wrong with having the user method returns the io.vertx.ext.auth.User interface, since the User interface is still the API for accessing user informations. The UserContext API can be returned from a userContext method instead. This avoids breaking the contract of the user method between 4.x and 5.0 Changes: Introduce a new userContext method returning the UserContext and change the return type of the user method to return the User type.
vietj
force-pushed
the
reinstate-routing-context-user
branch
from
632445b to
70f8343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
RoutingContext#user()method returns theio.vertx.ext.auth.Userinterface in Vert.x 4.x, its return type has been change toUserContextinstead (in addition of other changes), asUserContextis the preferred API for interacting with the user and theUserinterface actually represents theUser.However, there is nothing wrong with having the user method returns the
io.vertx.ext.auth.Userinterface, since theUserinterface is still the API for accessing user informations. TheUserContextAPI can be returned from auserContextmethod instead. This avoids breaking the contract of the user method between 4.x and 5.0Changes:
Introduce a new
userContextmethod returning theUserContextand change the return type of the user method to return theUsertype.