Storm ingest snippets for open source threat feeds #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cisphyx
reviewed
Sep 9, 2024
Comment on lines
+15
to
+19
| {[ou:org=$lib.gen.orgByFqdn("loobins.io") | ||
| :name="loobins" | ||
| :url="https://www.loobins.io/" | ||
| :desc="Living Off the Orchard: macOS Binaries (LOOBins) is designed to provide detailed information on various built-in macOS binaries and how they can be used by threat actors for malicious purposes." | ||
| ]} |
There was a problem hiding this comment.
This subquery won't actually execute since there are no nodes in the pipeline here
Cisphyx
reviewed
Sep 9, 2024
Comment on lines
+27
to
+29
| $body = $lib.json.load($body) | ||
|
|
||
| for $bin in $body { |
There was a problem hiding this comment.
Suggested change
| $body = $lib.json.load($body) | |
| for $bin in $body { | |
| for $bin in $resp.json() { |
Cisphyx
reviewed
Sep 9, 2024
Comment on lines
+40
to
+42
| for $path in $bin.paths { | ||
| [+(uses)> {[file:path=$path]}] | ||
| } |
There was a problem hiding this comment.
This loop will cause the it:prod:soft node to multiply, you can move the loop inside the edge add subquery (also more efficient that way)
Suggested change
| for $path in $bin.paths { | |
| [+(uses)> {[file:path=$path]}] | |
| } | |
| for $path in $bin.paths { | |
| [+(uses)> { | |
| for $path in $bin.paths {[file:path=$path]} | |
| }] |
Cisphyx
reviewed
Sep 9, 2024
| } | ||
|
|
||
| // Create technique nodes | ||
| for $ttp in $bin.example_use_cases { |
There was a problem hiding this comment.
Not sure what the intended output of the macro is, but should probably move this loop into a subquery to avoid duplicate it:prod:soft nodes being yielded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few of my storm snippets for ingesting open source threat feeds.
Also thrown in my
yara-family-namerwhich parses the malware family name from the YARA rule metadata.