-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and populate user on cronjobs and creator on triggers (SYN-8229, SYN-6850) #4043
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4043 +/- ##
==========================================
- Coverage 96.48% 96.40% -0.08%
==========================================
Files 256 256
Lines 59685 59749 +64
==========================================
+ Hits 57585 57604 +19
- Misses 2100 2145 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should discuss this; since previously we've talked about maintaining (or adding where it is missing) the creator
field onto structures as an immutable value, and then having a user
value that would represent who the associated query would execute as.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a small nit about whitespace in the tests but looks good otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to stage an Optic release to account for these changes (with a minver on the Optic side) to avoid compat issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
placing a hold on this for corresponding Optic updates
No description provided.