Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and populate user on cronjobs and creator on triggers (SYN-8229, SYN-6850) #4043

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Dec 17, 2024

No description provided.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 98.80952% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.40%. Comparing base (41ed219) to head (7c72475).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
synapse/lib/agenda.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4043      +/-   ##
==========================================
- Coverage   96.48%   96.40%   -0.08%     
==========================================
  Files         256      256              
  Lines       59685    59749      +64     
==========================================
+ Hits        57585    57604      +19     
- Misses       2100     2145      +45     
Flag Coverage Δ
linux 96.40% <98.80%> (-0.01%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

synapse/cortex.py Outdated Show resolved Hide resolved
invisig0th
invisig0th previously approved these changes Jan 3, 2025
Copy link
Contributor

@vEpiphyte vEpiphyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should discuss this; since previously we've talked about maintaining (or adding where it is missing) the creator field onto structures as an immutable value, and then having a user value that would represent who the associated query would execute as.

@Cisphyx Cisphyx changed the title Migrate cron creator to user and add shim for modifications (SYN-8229) Add and populate user on cronjobs and creator on triggers (SYN-8229) Jan 8, 2025
@Cisphyx Cisphyx changed the title Add and populate user on cronjobs and creator on triggers (SYN-8229) Add and populate user on cronjobs and creator on triggers (SYN-8229, SYN-6850) Jan 8, 2025
synapse/cortex.py Outdated Show resolved Hide resolved
MichaelSquires
MichaelSquires previously approved these changes Jan 14, 2025
Copy link
Contributor

@MichaelSquires MichaelSquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small nit about whitespace in the tests but looks good otherwise.

Copy link
Contributor

@invisig0th invisig0th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to stage an Optic release to account for these changes (with a minver on the Optic side) to avoid compat issues?

Copy link
Contributor

@invisig0th invisig0th left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

placing a hold on this for corresponding Optic updates

@invisig0th invisig0th dismissed vEpiphyte’s stale review January 14, 2025 17:48

Discussed and accounted for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants