Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration test for session management #325

Merged
merged 16 commits into from
Feb 14, 2022
Merged

Conversation

jeremyprime
Copy link
Collaborator

Summary

Add an integration test for session management.

Description

Check that sessions are cleaned up after a read or write operation.

Related Issue

#323

Additional Reviewers

@alexey-temnikov
@alexr-bq
@Aryex
@jonathanl-bq

pipe.commit()
val ret = pipe.commit()
// Ensure all connections are closed, including read connections used by the write operation
val _ = pipeFactory.closeJdbcLayers()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing a few more permutations I found that a write (without a read) created a read connection for getting schema/column information from Vertica. The read connection was not being closed, resulting in a dangling session in that case.

@jeremyprime jeremyprime merged commit 5fabd07 into main Feb 14, 2022
@jeremyprime jeremyprime deleted the singleton-connection branch February 14, 2022 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants