Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replication reconciler for VerticaReplicator #773

Merged
merged 12 commits into from
Apr 22, 2024
Merged

Add replication reconciler for VerticaReplicator #773

merged 12 commits into from
Apr 22, 2024

Conversation

jizhuoyu
Copy link
Collaborator

@jizhuoyu jizhuoyu commented Apr 16, 2024 •
edited by spilchen
Loading

This pull request modifies the Vertica replicator controller to invoke the replication command synchronously. Additionally, it introduces new status conditions within VerticaReplicator to monitor the controller's various states.

@jizhuoyu jizhuoyu self-assigned this Apr 17, 2024
@jizhuoyu jizhuoyu marked this pull request as ready for review April 17, 2024 06:25
@jizhuoyu jizhuoyu requested a review from spilchen as a code owner April 17, 2024 06:25
spilchen
spilchen reviewed Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There aren't any e2e tests. As mention in scrum, lets handle that as a follow-on task.

api/v1beta1/helpers.go Outdated Show resolved Hide resolved
pkg/controllers/vdb/podfacts.go Outdated Show resolved Hide resolved
pkg/names/names.go Outdated Show resolved Hide resolved
pkg/vadmin/replication_start_at.go Outdated Show resolved Hide resolved
pkg/vadmin/replication_start_vc.go Outdated Show resolved Hide resolved
pkg/controllers/vrep/replication_reconciler.go Show resolved Hide resolved
pkg/controllers/vrep/replication_reconciler.go Outdated Show resolved Hide resolved
pkg/controllers/vrep/replication_reconciler.go Outdated Show resolved Hide resolved
pkg/controllers/vrep/replication_reconciler.go Show resolved Hide resolved
pkg/controllers/vrep/replication_reconciler.go Show resolved Hide resolved
spilchen
spilchen reviewed Apr 19, 2024
View reviewed changes
pkg/vadmin/replication_start_vc.go Outdated Show resolved Hide resolved
pkg/controllers/vrep/vdbverify_reconciler.go Outdated Show resolved Hide resolved
pkg/controllers/vrep/replication_reconciler.go Outdated Show resolved Hide resolved
pkg/controllers/vrep/suite_test.go Outdated Show resolved Hide resolved
pkg/controllers/vrep/vdbverify_reconciler_test.go Show resolved Hide resolved
spilchen
spilchen approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I just had two suggested rewording for the event message. Approving since that change should be trivial.

pkg/controllers/vrep/vdbverify_reconciler.go Outdated Show resolved Hide resolved
pkg/controllers/vrep/vdbverify_reconciler.go Outdated Show resolved Hide resolved
@jizhuoyu
Apply suggestions from code review
cc6f521 
Co-authored-by: spilchen <mspilchen@opentext.com>
@jizhuoyu jizhuoyu merged commit baf6174 into vnext Apr 22, 2024
31 checks passed
@jizhuoyu jizhuoyu deleted the zji/replication-call-api branch April 22, 2024 21:59
cchen-vertica pushed a commit that referenced this pull request Jul 17, 2024
@jizhuoyu @cchen-vertica
Add replication reconciler for VerticaReplicator (#773)
cd8a967 
This pull request modifies the Vertica replicator controller to invoke
the replication command synchronously. Additionally, it introduces new
status conditions within VerticaReplicator to monitor the controller's
various states.

---------

Co-authored-by: spilchen <mspilchen@opentext.com>
cchen-vertica pushed a commit that referenced this pull request Jul 17, 2024
@jizhuoyu @cchen-vertica
Add replication reconciler for VerticaReplicator (#773)
aadedd6 
This pull request modifies the Vertica replicator controller to invoke
the replication command synchronously. Additionally, it introduces new
status conditions within VerticaReplicator to monitor the controller's
various states.

---------

Co-authored-by: spilchen <mspilchen@opentext.com>
cchen-vertica pushed a commit that referenced this pull request Jul 24, 2024
@jizhuoyu @cchen-vertica
Add replication reconciler for VerticaReplicator (#773)
72f307e 
This pull request modifies the Vertica replicator controller to invoke
the replication command synchronously. Additionally, it introduces new
status conditions within VerticaReplicator to monitor the controller's
various states.

---------

Co-authored-by: spilchen <mspilchen@opentext.com>
cchen-vertica pushed a commit that referenced this pull request Jul 24, 2024
@jizhuoyu @cchen-vertica
Add replication reconciler for VerticaReplicator (#773)
3d1661a 
This pull request modifies the Vertica replicator controller to invoke
the replication command synchronously. Additionally, it introduces new
status conditions within VerticaReplicator to monitor the controller's
various states.

---------

Co-authored-by: spilchen <mspilchen@opentext.com>
cchen-vertica pushed a commit that referenced this pull request Jul 24, 2024
@jizhuoyu @cchen-vertica
Add replication reconciler for VerticaReplicator (#773)
cae3b56 
This pull request modifies the Vertica replicator controller to invoke
the replication command synchronously. Additionally, it introduces new
status conditions within VerticaReplicator to monitor the controller's
various states.

---------

Co-authored-by: spilchen <mspilchen@opentext.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roypaulin roypaulin roypaulin left review comments

@spilchen spilchen spilchen approved these changes

@chinhtranvan chinhtranvan Awaiting requested review from chinhtranvan

Assignees

@jizhuoyu jizhuoyu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jizhuoyu @spilchen @chinhtranvan @roypaulin