VAULT-893 Supervisord #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Hochman <danielhochman@users.noreply.github.com>
* update dependencies
This allows ratelimit to run on Kubernetes with configuration from a configmap.
Signed-off-by: Steve Sloka <steves@heptio.com>
Fixes envoyproxy#71 Signed-off-by: Matt Klein <mklein@lyft.com>
Signed-off-by: Matt Klein <mklein@lyft.com>
Fix problem:
src/service_cmd/runner/runner.go:10:2: cannot find package "github.com/lyft/ratelimit/proto/ratelimit" in any of:
/usr/local/go/src/github.com/lyft/ratelimit/vendor/github.com/lyft/ratelimit/proto/ratelimit (vendor tree)
/usr/local/go/src/vendor/github.com/lyft/ratelimit/proto/ratelimit
/usr/local/go/src/github.com/lyft/ratelimit/proto/ratelimit (from $GOROOT)
/go/src/github.com/lyft/ratelimit/proto/ratelimit (from $GOPATH)
The command '/bin/sh -c go build -o /usr/local/bin/ratelimit src/service_cmd/main.go' returned a non-zero code: 1
This adds support for TLS connections to redis as well as support for authentication. Somewhat related to issue verygoodsecurity#61
Description: this patch allows a consumer of the server package to customize the name of the healthchecker. Signed-off-by: Jose Nino <jnino@lyft.com>
Description: envoyproxy#102 allowed for some customization. This PR makes the types public so that other servers can use this implementation. Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: tangxinfa <tangxinfa@gmail.com>
Signed-off-by: Clara Andrew-Wani <candrewwani@gmail.com>
Signed-off-by: Itay Donanhirsh <itay@bazoo.org>
Signed-off-by: zufardhiyaulhaq <zufardhiyaulhaq@gmail.com>
… config. (envoyproxy#192) Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: William Albertus Dembo <w.albertusd@gmail.com>
Signed-off-by: Yuki Sawa <yukisawa@gmail.com>
Signed-off-by: Sasha Kulbii <okulbii@wayfair.com>
…nvoyproxy#172) MEMCACHE_HOST_PORT=host:port must be set with BACKEND_TYPE=memcache To minimize roundtrips when getting multiple keys, the memcache implementation does a GetMulti to fetch the existing rate limit usage and does increments asynchronously in background goroutines, since the memcache API doesn't offer multi-increment. Resolves envoyproxy#140 Signed-off-by: David Weitzman <dweitzman@pinterest.com>
Signed-off-by: Kateryna Nezdolii <nezdolik@spotify.com>
Signed-off-by: cpaika <paika.christopher@gmail.com>
* Add Circle Config * Touch to build * Move to expected path * Use Docker Command * Do it all here then * Env * Add Readme * Actual README
|
Can we split this pull request into two PRs?
Maybe it will be easier in future to distinguish between our changes and upstream changes |
vmykh
reviewed
Feb 4, 2021
vmykh
approved these changes
Feb 4, 2021
|
retest me please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You only need to look at commit abe715e
The rest is pulled from envoyproxy/ratelimit
I did test this by sh into docker and killing the process. It came back.