Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validator pkg #14

Merged
merged 1 commit into from
Apr 12, 2022
Merged

add validator pkg #14

merged 1 commit into from
Apr 12, 2022

Conversation

veezhang
Copy link
Contributor

used for parameter validation.

@veezhang veezhang requested a review from nianiaJR April 12, 2022 10:51
@codecov-commenter
Copy link

Codecov Report

Merging #14 (66d91e2) into master (5bf3429) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        12    +1     
  Lines          531       553   +22     
=========================================
+ Hits           531       553   +22
Impacted Files Coverage Δ
validator/validator.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bf3429...66d91e2. Read the comment docs.

kqzh
kqzh approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@kqzh kqzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kqzh kqzh merged commit 968818d into vesoft-inc:master Apr 12, 2022
nianiaJR
nianiaJR approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@nianiaJR nianiaJR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamieliu1023 jamieliu1023 mentioned this pull request Apr 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nianiaJR nianiaJR nianiaJR approved these changes

@kqzh kqzh kqzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@veezhang @codecov-commenter @nianiaJR @kqzh