Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ssl connection pool #10

Merged
merged 2 commits into from
Dec 28, 2021
Merged

add ssl connection pool #10

merged 2 commits into from
Dec 28, 2021

Conversation

HarrisChu
Copy link
Contributor

as title

@HarrisChu HarrisChu requested a review from Nicole00 December 28, 2021 06:47
Nicole00
Nicole00 approved these changes Dec 28, 2021 •
edited
Loading
View reviewed changes
client.go
isSucceed bool
rows int32
errorMsg string
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need errorCode?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error code is less useful for user.

just like this
image

client.go
rootCAPath: rootCAPath,
certPath: certPath,
privateKeyPath: privateKeyPath,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For SelfSign, is password in privateKeyPath file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nebula-go doesn't support password yet ..

@darionyaphet darionyaphet merged commit c237866 into vesoft-inc:master Dec 28, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darionyaphet darionyaphet darionyaphet left review comments

@Nicole00 Nicole00 Nicole00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HarrisChu @darionyaphet @Nicole00