Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for agent #22

Merged
merged 3 commits into from
Dec 30, 2021
Merged

add support for agent #22

merged 3 commits into from
Dec 30, 2021

Conversation

pengweisong
Copy link
Contributor

Refactor br:

  1. remove ssh dependency.
  2. use nebula agent to upload/download backup files.
  3. use sdk instead of binary client to access external storage.
  4. support s3 external storage.

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pengweisong pengweisong mentioned this pull request Dec 16, 2021
Merged
7 tasks
Nivras
Nivras reviewed Dec 21, 2021
View reviewed changes
pkg/clients/agent.go Outdated Show resolved Hide resolved
critical27
critical27 reviewed Dec 28, 2021
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive my poor Go... If the comments is totally wrong, just ignore them.

Awesome work~

pkg/clients/meta.go Show resolved Hide resolved
pkg/clients/meta.go Show resolved Hide resolved
pkg/utils/utils.go Show resolved Hide resolved
pkg/config/backup.go Show resolved Hide resolved
pkg/cleanup/cleanup.go Show resolved Hide resolved
pkg/restore/restore.go Outdated Show resolved Hide resolved
pkg/restore/restore.go Show resolved Hide resolved
@critical27
Copy link
Contributor

critical27 commented Dec 28, 2021 •
edited
Loading

BTW, maybe we need to add some link to agent, and ask user to start agent before backup

@pengweisong
Copy link
Contributor Author

BTW, maybe we need to add some link to agent, and ask user to start agent before backup

In the future, the agent will be started by default?

@critical27
Copy link
Contributor

BTW, maybe we need to add some link to agent, and ask user to start agent before backup

In the future, the agent will be started by default?

If we integrate agent into core's rpm, yes

@pengweisong
refactor br to remove dependency on ssh:
1bf59a7 
1. remove ssh and depend on agent now.
2. rafactor most of the codes
@pengweisong pengweisong marked this pull request as ready for review December 30, 2021 10:11
@critical27 critical27 merged commit c6f8c6a into vesoft-inc:master Dec 30, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nivras Nivras Nivras left review comments

@critical27 critical27 critical27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pengweisong @CLAassistant @critical27 @Nivras