Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test issues #23

Merged
merged 6 commits into from
Jan 21, 2022
Merged

Fix test issues #23

merged 6 commits into from
Jan 21, 2022

Conversation

pengweisong
Copy link
Contributor

Fix some bugs:

  1. When there are not all conf in some nodes, scripts/nebula.service start all will be executed failed. I will changed it to stop service one by one instead of stopping them at the same time.
  2. When there are multi-metads which are not in the same machine, it will restore failed. It requires supporting transfer files between BR CLI and agent. It is a little wired, then I add some warnings in the readme and recommend the user using s3-compatible storage in the production environment.
  3. Cleanup all files in different machines in local mode.

critical27
critical27 approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job~

@critical27 critical27 merged commit ce9639f into vesoft-inc:master Jan 21, 2022
@jamieliu1023 jamieliu1023 mentioned this pull request Jan 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 approved these changes

@FangJinhe FangJinhe Awaiting requested review from FangJinhe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pengweisong @critical27