Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cypher parameter #127

Merged
merged 2 commits into from
Dec 22, 2021
Merged

support cypher parameter #127

merged 2 commits into from
Dec 22, 2021

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Sep 2, 2021

No description provided.

@czpmango czpmango changed the title support cypher parameter [DNM] support cypher parameter Sep 2, 2021
main.go Show resolved Hide resolved
fix compatibility

small fix

tmp add slice2Nlist

fix

support map

fix limit int

delete replace nebula-go

update go.mod

rebase
@czpmango czpmango changed the title [DNM] support cypher parameter support cypher parameter Dec 21, 2021
@czpmango czpmango requested review from jievince and Aiee December 21, 2021 08:51
main.go Outdated
Comment on lines 520 to 522
// unsupport other Value type, use this function carefully
err = fmt.Errorf("Do not support convert %T to nebula.Value", any)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could specify what value types are supported to be parameterized.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jievince jievince merged commit 4dee336 into vesoft-inc:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants