Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The unit of argument timeout is actual millisecond #200

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Jan 9, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Fix #203

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@jievince jievince requested review from Aiee and foesa-yang January 9, 2023 02:37
@jievince jievince added the doc affected PR: improvements or additions to documentation label Jan 9, 2023
@jievince jievince changed the title The unit off argument timeout is actual millisecond The unit of argument timeout is actual millisecond Jan 9, 2023
Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@Aiee Aiee merged commit 946dad0 into master Jan 9, 2023
@Aiee Aiee deleted the timeout-unit branch January 9, 2023 03:16
@foesa-yang
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The unit of timeout argument should be millisecond not second
3 participants