Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the tck format for the output of EXPLAIN #210

Merged
merged 3 commits into from
Apr 4, 2023

Conversation

AntiTopQuark
Copy link
Contributor

@AntiTopQuark AntiTopQuark commented Mar 19, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

vesoft-inc/nebula#5274

Description:

rt, Support the tck format for the output of EXPLAIN

How do you solve it?

Modify the style of pretty/table to produce results in the TCK format.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

related link:

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2023

CLA assistant check
All committers have signed the CLA.

@xtcyclist
Copy link

Hi. There are some build errors. Please address them.

@Sophie-Xie Sophie-Xie requested a review from jievince March 29, 2023 10:36
@AntiTopQuark
Copy link
Contributor Author

Hi. There are some build errors. Please address them.

Hello, the reason for the building failure is due to the missing function called 'MakePlanByTck' in the dependent 'nebula-go' library.
I have already implemented this function and submitted a PR: vesoft-inc/nebula-go#265
Therefore, it might be necessary to first merge the PR for the 'nebula-go' library before the current repository (nebula-console) can be successfully compiled.

@Sophie-Xie
Copy link

Hi. There are some build errors. Please address them.

Hello, the reason for the building failure is due to the missing function called 'MakePlanByTck' in the dependent 'nebula-go' library. I have already implemented this function and submitted a PR: vesoft-inc/nebula-go#265 Therefore, it might be necessary to first merge the PR for the 'nebula-go' library before the current repository (nebula-console) can be successfully compiled.

vesoft-inc/nebula-go#265 merged and nebula-console updated the dependent. But we can't rebase your pr, pls rebase it and try the CI, thanks.

Copy link
Contributor

@jievince jievince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jievince jievince merged commit 838a0eb into vesoft-inc:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants