Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add switch for tagless #100

Merged
merged 2 commits into from
Oct 19, 2022
Merged

add switch for tagless #100

merged 2 commits into from
Oct 19, 2022

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Oct 17, 2022

close #99

@codecov-commenter
Copy link

Codecov Report

Base: 55.42% // Head: 55.51% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (f53fc85) compared to base (775f7e7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #100      +/-   ##
============================================
+ Coverage     55.42%   55.51%   +0.09%     
  Complexity       81       81              
============================================
  Files            17       17              
  Lines          1411     1414       +3     
  Branches        267      267              
============================================
+ Hits            782      785       +3     
  Misses          489      489              
  Partials        140      140              
Impacted Files Coverage Δ
...la/com/vesoft/exchange/common/config/Configs.scala 62.12% <100.00%> (+0.13%) ⬆️
.../vesoft/exchange/common/config/SchemaConfigs.scala 72.30% <100.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nicole00 Nicole00 merged commit 2d286d2 into vesoft-inc:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support switch to decide whether generate tagless key when writing sst file
3 participants