-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support path parameterization for file data #113
Conversation
Great improvement~~ |
In practical using, we will create a scheduler task, the |
Codecov ReportBase: 55.28% // Head: 55.85% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #113 +/- ##
============================================
+ Coverage 55.28% 55.85% +0.56%
Complexity 81 81
============================================
Files 18 18
Lines 1438 1461 +23
Branches 271 277 +6
============================================
+ Hits 795 816 +21
- Misses 501 502 +1
- Partials 142 143 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
reload: String = "") | ||
reload: String = "", | ||
file: Boolean = false, | ||
path: String = "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a great work, thanks!
maybe we should use more understandable variable name,how about change file
to variable
, path
to param
?
this pr look good to me, and the code needs to be formatted please. @Codelone |
It has been changed,please check it。 |
I just noticed there's no test for the variable path for config file, could you please add some test to make sure it works? |
test case method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
file
is boolean,path
is srting
Sometimes, we need to use a variable path to execute commands, so replace the file path of PARQUET、ORC、 JSON、CSV by adding arguments。
if need use ,need to set " -f -p param1=/home/xxx.csv,param2=/home/xxx.csv "
then tag/edge path in application.conf needs to be set to param1, param2.
if don't need it , don't use " -f -p ".