Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support the vid with specific string prefix #149

Merged
merged 4 commits into from
Jul 6, 2023

Conversation

Nicole00
Copy link
Contributor

@Nicole00 Nicole00 commented Jul 5, 2023

close #133

wey-gu
wey-gu previously approved these changes Jul 5, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.33 🎉

Comparison is base (934c23f) 56.24% compared to head (0fdb82f) 56.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #149      +/-   ##
============================================
+ Coverage     56.24%   56.57%   +0.33%     
  Complexity       79       79              
============================================
  Files            18       18              
  Lines          1554     1566      +12     
  Branches        297      297              
============================================
+ Hits            874      886      +12     
  Misses          519      519              
  Partials        161      161              
Impacted Files Coverage Δ
...la/com/vesoft/exchange/common/config/Configs.scala 62.55% <100.00%> (+0.52%) ⬆️
.../vesoft/exchange/common/config/SchemaConfigs.scala 74.11% <100.00%> (+0.94%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Nicole00 Nicole00 merged commit 3f27691 into vesoft-inc:master Jul 6, 2023
@Nicole00 Nicole00 deleted the prefix_vid branch July 6, 2023 09:34
@Nicole00 Nicole00 added the doc affected PR: improvements or additions to documentation label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support the vid with specific string prefix
3 participants