Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error amount limit #58

Merged
merged 2 commits into from
Jan 17, 2022
Merged

add error amount limit #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da50044
duration for sst
Nicole00 Jan 17, 2022
07ca437
add error amount limit
Nicole00 Jan 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions exchange-common/src/main/scala/com/vesoft/exchange/common/processor/Processor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,9 @@ trait Processor extends Serializable {
val jtsGeom = new org.locationtech.jts.io.WKTReader().read(wkt)
convertJTSGeometryToGeography(jtsGeom)
}
case PropertyType.DURATION => {
throw new IllegalArgumentException("do not support data type duration.")
}
}
}

Expand Down
6 changes: 6 additions & 0 deletions ...xchange_spark_2.2/src/main/scala/com/vesoft/nebula/exchange/processor/EdgeProcessor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import com.vesoft.exchange.common.utils.NebulaUtils.DEFAULT_EMPTY_VALUE
import com.vesoft.exchange.common.writer.{GenerateSstFile, NebulaGraphClientWriter, NebulaSSTWriter}
import com.vesoft.exchange.common.VidType
import com.vesoft.nebula.encoder.NebulaCodecImpl
import com.vesoft.nebula.exchange.TooManyErrorsException
import com.vesoft.nebula.meta.EdgeItem
import org.apache.commons.codec.digest.MurmurHash2
import org.apache.log4j.Logger
Expand Down Expand Up @@ -72,6 +73,11 @@ class EdgeProcessor(spark: SparkSession,
} else {
errorBuffer.append(failStatement)
batchFailure.add(1)
if (batchFailure.value >= config.errorConfig.errorMaxSize) {
throw TooManyErrorsException(
s"There are too many failed batches, batch amount: ${batchFailure.value}, " +
s"your config max error size: ${config.errorConfig.errorMaxSize}")
}
}
}
if (errorBuffer.nonEmpty) {
Expand Down
6 changes: 6 additions & 0 deletions ...nge_spark_2.2/src/main/scala/com/vesoft/nebula/exchange/processor/VerticesProcessor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import com.vesoft.exchange.common.utils.NebulaUtils.DEFAULT_EMPTY_VALUE
import com.vesoft.exchange.common.writer.{GenerateSstFile, NebulaGraphClientWriter, NebulaSSTWriter}
import com.vesoft.exchange.common.VidType
import com.vesoft.nebula.encoder.NebulaCodecImpl
import com.vesoft.nebula.exchange.TooManyErrorsException
import com.vesoft.nebula.meta.TagItem
import org.apache.commons.codec.digest.MurmurHash2
import org.apache.log4j.Logger
Expand Down Expand Up @@ -79,6 +80,11 @@ class VerticesProcessor(spark: SparkSession,
} else {
errorBuffer.append(failStatement)
batchFailure.add(1)
if (batchFailure.value >= config.errorConfig.errorMaxSize) {
throw TooManyErrorsException(
s"There are too many failed batches, batch amount: ${batchFailure.value}, " +
s"your config max error size: ${config.errorConfig.errorMaxSize}")
}
}
}
if (errorBuffer.nonEmpty) {
Expand Down
6 changes: 6 additions & 0 deletions ...xchange_spark_2.4/src/main/scala/com/vesoft/nebula/exchange/processor/EdgeProcessor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import com.vesoft.exchange.common.utils.NebulaUtils.DEFAULT_EMPTY_VALUE
import com.vesoft.exchange.common.writer.{GenerateSstFile, NebulaGraphClientWriter, NebulaSSTWriter}
import com.vesoft.exchange.common.VidType
import com.vesoft.nebula.encoder.NebulaCodecImpl
import com.vesoft.nebula.exchange.TooManyErrorsException
import com.vesoft.nebula.meta.EdgeItem
import org.apache.commons.codec.digest.MurmurHash2
import org.apache.log4j.Logger
Expand Down Expand Up @@ -73,6 +74,11 @@ class EdgeProcessor(spark: SparkSession,
} else {
errorBuffer.append(failStatement)
batchFailure.add(1)
if (batchFailure.value >= config.errorConfig.errorMaxSize) {
throw TooManyErrorsException(
s"There are too many failed batches, batch amount: ${batchFailure.value}, " +
s"your config max error size: ${config.errorConfig.errorMaxSize}")
}
}
}
if (errorBuffer.nonEmpty) {
Expand Down
6 changes: 6 additions & 0 deletions ...nge_spark_2.4/src/main/scala/com/vesoft/nebula/exchange/processor/VerticesProcessor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import com.vesoft.exchange.common.utils.NebulaUtils.DEFAULT_EMPTY_VALUE
import com.vesoft.exchange.common.writer.{GenerateSstFile, NebulaGraphClientWriter, NebulaSSTWriter}
import com.vesoft.exchange.common.VidType
import com.vesoft.nebula.encoder.NebulaCodecImpl
import com.vesoft.nebula.exchange.TooManyErrorsException
import com.vesoft.nebula.meta.TagItem
import org.apache.commons.codec.digest.MurmurHash2
import org.apache.log4j.Logger
Expand Down Expand Up @@ -81,6 +82,11 @@ class VerticesProcessor(spark: SparkSession,
} else {
errorBuffer.append(failStatement)
batchFailure.add(1)
if (batchFailure.value >= config.errorConfig.errorMaxSize) {
throw TooManyErrorsException(
s"There are too many failed batches, batch amount: ${batchFailure.value}, " +
s"your config max error size: ${config.errorConfig.errorMaxSize}")
}
}
}
if (errorBuffer.nonEmpty) {
Expand Down
6 changes: 6 additions & 0 deletions ...xchange_spark_3.0/src/main/scala/com/vesoft/nebula/exchange/processor/EdgeProcessor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import com.vesoft.exchange.common.utils.NebulaUtils.DEFAULT_EMPTY_VALUE
import com.vesoft.exchange.common.writer.{GenerateSstFile, NebulaGraphClientWriter, NebulaSSTWriter}
import com.vesoft.exchange.common.VidType
import com.vesoft.nebula.encoder.NebulaCodecImpl
import com.vesoft.nebula.exchange.TooManyErrorsException
import com.vesoft.nebula.meta.EdgeItem
import org.apache.commons.codec.digest.MurmurHash2
import org.apache.log4j.Logger
Expand Down Expand Up @@ -73,6 +74,11 @@ class EdgeProcessor(spark: SparkSession,
} else {
errorBuffer.append(failStatement)
batchFailure.add(1)
if (batchFailure.value >= config.errorConfig.errorMaxSize) {
throw TooManyErrorsException(
s"There are too many failed batches, batch amount: ${batchFailure.value}, " +
s"your config max error size: ${config.errorConfig.errorMaxSize}")
}
}
}
if (errorBuffer.nonEmpty) {
Expand Down
6 changes: 6 additions & 0 deletions ...nge_spark_3.0/src/main/scala/com/vesoft/nebula/exchange/processor/VerticesProcessor.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import com.vesoft.exchange.common.utils.NebulaUtils.DEFAULT_EMPTY_VALUE
import com.vesoft.exchange.common.writer.{GenerateSstFile, NebulaGraphClientWriter, NebulaSSTWriter}
import com.vesoft.exchange.common.VidType
import com.vesoft.nebula.encoder.NebulaCodecImpl
import com.vesoft.nebula.exchange.TooManyErrorsException
import com.vesoft.nebula.meta.TagItem
import org.apache.commons.codec.digest.MurmurHash2
import org.apache.log4j.Logger
Expand Down Expand Up @@ -81,6 +82,11 @@ class VerticesProcessor(spark: SparkSession,
} else {
errorBuffer.append(failStatement)
batchFailure.add(1)
if (batchFailure.value >= config.errorConfig.errorMaxSize) {
throw TooManyErrorsException(
s"There are too many failed batches, batch amount: ${batchFailure.value}, " +
s"your config max error size: ${config.errorConfig.errorMaxSize}")
}
}
}
if (errorBuffer.nonEmpty) {
Expand Down