Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update thrift files and support duration data types #175

Merged
merged 4 commits into from
Dec 28, 2021
Merged

Update thrift files and support duration data types #175

merged 4 commits into from
Dec 28, 2021

Conversation

jievince
Copy link
Contributor

No description provided.

@jievince jievince requested a review from Aiee December 23, 2021 07:59
Aiee
Aiee reviewed Dec 23, 2021
View reviewed changes
Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests in TestServiceDataIO to test the serialization of duration

@jievince
Copy link
Contributor Author

Please add some tests in TestServiceDataIO to test the serialization of duration

ok

@jievince jievince force-pushed the duration branch 2 times, most recently from b6a4ae2 to a1d786d Compare December 28, 2021 03:07
@jievince jievince force-pushed the duration branch 2 times, most recently from 2f586b9 to d131f44 Compare December 28, 2021 03:26
@jievince jievince requested a review from Aiee December 28, 2021 03:49
@Aiee Aiee merged commit 4307f62 into vesoft-inc:master Dec 28, 2021
@jievince jievince deleted the duration branch December 28, 2021 03:53
@jievince jievince mentioned this pull request Dec 28, 2021
Closed
@jamieliu1023 jamieliu1023 mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aiee Aiee Awaiting requested review from Aiee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jievince @Aiee