Update correct website URL for README.md #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
ping @Aiee |
Aiee
reviewed
Jan 10, 2023
| @@ -45,9 +45,9 @@ For example: | |||
|
|
|||
| ## Usage example | |||
|
|
|||
| [Simple Code Example](https://github.com/vesoft-inc/nebula-go/tree/master/basic_example/graph_client_basic_example.go) | |||
| [Simple Code Example](https://github.com/vesoft-inc/nebula-go/blob/release-3.1/basic_example/graph_client_basic_example.go) | |||
|
|
|||
There was a problem hiding this comment.
Please update the link to direct to master branch. i.g. https://github.com/vesoft-inc/nebula-go/blob/master/examples/basic_example/graph_client_basic_example.go
There was a problem hiding this comment.
Thanks for the reminder, I've updated the two correct links directly to the master branch, please check it.
Update the link to direct to master branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
The operation initiated no issues.
Description:
Due to the expiration of the URL link, the Golang official website description (
https://pkg.go.dev/github.com/vesoft-inc/nebula-go/v3@v3.3.1#section-readme) cannot normally view the moduleUsage example, which creates a bad user experience.How do you solve it?
Update the correct website URL link in branch
release-3.1.Special notes for your reviewer, ex. impact of this fix, design document, etc: