-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix session leak #269
fix session leak #269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 61.26% 61.28% +0.01%
==========================================
Files 9 9
Lines 2308 2309 +1
==========================================
+ Hits 1414 1415 +1
Misses 749 749
Partials 145 145
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
this pr would simply fix the issue, but we process session in separate functions. (new session, update or push to list) |
maybe we would quick fix first, and then enhance these code in future |
Makes sense to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Thanks for your contribution.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#268
Description:
How do you solve it?
当new session 后,及时更新当前使用的session引用
Special notes for your reviewer, ex. impact of this fix, design document, etc: