Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #272 #273

Merged
merged 3 commits into from
Apr 12, 2023
Merged

fix #272 #273

merged 3 commits into from
Apr 12, 2023

Conversation

HarrisChu
Copy link
Contributor

@HarrisChu HarrisChu commented Apr 10, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #272

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@HarrisChu HarrisChu changed the title add test fix vesoft-inc#272 Apr 11, 2023
@HarrisChu HarrisChu changed the title fix vesoft-inc#272 fix #272 Apr 11, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.81 🎉

Comparison is base (3ed8926) 61.30% compared to head (dbf6afd) 62.12%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   61.30%   62.12%   +0.81%     
==========================================
  Files           9        9              
  Lines        2308     2305       -3     
==========================================
+ Hits         1415     1432      +17     
+ Misses        748      734      -14     
+ Partials      145      139       -6     
Impacted Files Coverage Δ
connection_pool.go 81.46% <100.00%> (+2.72%) ⬆️
session.go 50.80% <100.00%> (+3.10%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HarrisChu HarrisChu requested a review from Aiee April 11, 2023 01:02
Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@Aiee Aiee merged commit fae48de into vesoft-inc:master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure recover for client side
3 participants