Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add minimal example in the readme #307

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Jan 23, 2024

As said in #303, it would be better to add a minimal example in the README.md.

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@haoxins haoxins marked this pull request as ready for review January 23, 2024 16:22
@haoxins
Copy link
Collaborator Author

haoxins commented Jan 31, 2024

cc @Nicole00

Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Thanks

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0307aa) 63.17% compared to head (391175d) 63.17%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #307   +/-   ##
=======================================
  Coverage   63.17%   63.17%           
=======================================
  Files           9        9           
  Lines        2466     2466           
=======================================
  Hits         1558     1558           
  Misses        778      778           
  Partials      130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nicole00 Nicole00 merged commit 5d9b457 into vesoft-inc:master Jan 31, 2024
20 checks passed
@haoxins haoxins deleted the chore-docs branch January 31, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants