Add ShowSpaces for SessionPool #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoxins
force-pushed
the
feat-add-show-space
branch
5 times, most recently
from
0fe03f1 to
abbe765
Compare
haoxins
force-pushed
the
feat-add-show-space
branch
from
abbe765 to
dbf83de
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #313 +/- ##
==========================================
+ Coverage 63.69% 63.70% +0.01%
==========================================
Files 10 10
Lines 2570 2579 +9
==========================================
+ Hits 1637 1643 +6
- Misses 795 797 +2
- Partials 138 139 +1 ☔ View full report in Codecov by Sentry. |
Nicole00
reviewed
Feb 4, 2024
session_pool.go
Outdated
| @@ -287,6 +287,18 @@ func (pool *SessionPool) ExecuteAndCheck(q string) (*ResultSet, error) { | |||
| return rs, nil | |||
| } | |||
|
|
|||
| func (pool *SessionPool) ShowSpaces() ([]LabelName, error) { | |||
There was a problem hiding this comment.
its ambiguous to reuse the LabelName, can we redefine a struct SpaceName?
Nicole00
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#311
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: