Connection pool: put conn to idle queue if auth responded with unsuccessful code #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicole00
reviewed
Apr 8, 2024
| return nil, err | ||
| } | ||
|
|
||
| // Check auth response | ||
| if resp.GetErrorCode() != nebula.ErrorCode_SUCCEEDED { | ||
| // if authentication responded with unsuccessful code, put connection back | ||
| pool.pushBack(conn) |
Nicole00
approved these changes
Apr 8, 2024
haoxins
approved these changes
Apr 8, 2024
HarrisChu
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#334
Description:
As in connection_pool.go, ConnectionPool deactivates the current connection by putting it to idle queue if authentication failed (i.e. conn.authenticate returns an non-nil error). However, if authentication returns an nil error but with an unsuccessful ErrorCode, the connection won't be deactivated. Therefore, consecutive unsuccessful responses of authentication could eventually use up the connection pool, causing no new connections is able to be created.
How do you solve it?
I treat both authentication failure scenarios with the same handling, that the connection is put back to idle queue if failed.
Special notes for your reviewer, ex. impact of this fix, design document, etc: