Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the codebase #349

Merged
merged 5 commits into from
Sep 14, 2024
Merged

Enhance the codebase #349

merged 5 commits into from
Sep 14, 2024

Conversation

haoxins
Copy link
Collaborator

@haoxins haoxins commented Aug 29, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@haoxins
Copy link
Collaborator Author

haoxins commented Aug 29, 2024

for the docker-compose to docker compose, see
https://github.com/orgs/community/discussions/116610

@haoxins haoxins force-pushed the enhance branch 7 times, most recently from 169cf27 to b182e2c Compare August 30, 2024 03:40
wey-gu
wey-gu previously approved these changes Sep 6, 2024
@wey-gu
Copy link
Contributor

wey-gu commented Sep 7, 2024

Ping @HarrisChu @Nicole00

change SessionPool's List as List ref

remove unused tz field in the SessionPool

Revert "change SessionPool's List as List ref"

This reverts commit 890329f.

debug
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.36%. Comparing base (d12bd94) to head (5b4c458).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
connection.go 0.00% 2 Missing ⚠️
configs.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
+ Coverage   64.23%   64.36%   +0.12%     
==========================================
  Files          11       11              
  Lines        2961     2963       +2     
==========================================
+ Hits         1902     1907       +5     
- Misses        896      897       +1     
+ Partials      163      159       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nicole00 Nicole00 merged commit 4e4de32 into vesoft-inc:master Sep 14, 2024
26 checks passed
@haoxins haoxins deleted the enhance branch September 14, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants