Split retry and timeout error #357
Merged
+725
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HarrisChu
commented
Sep 19, 2024
•
HarrisChu
commented
- split retry for session invalid an error
- update error code
- cherry-pick feat: add int64 param #348
* feat: add int64 param close: vesoft-inc#288 * ci: use docker compose as ci runner dropped docker-compose * fix: use test_client to test int64 param instead * fix example for int64 test - also hardcode the container name for test * address Haris' comment
wenhaocs
reviewed
Sep 20, 2024
| ErrorCode_E_PART_DISABLED ErrorCode = -34 | ||
| ErrorCode_E_PART_ALREADY_STARTED ErrorCode = -35 | ||
| ErrorCode_E_PART_ALREADY_STOPPED ErrorCode = -36 | ||
| ErrorCode_E_QUERY_TIMEDOUT ErrorCode = -37 |
There was a problem hiding this comment.
Are all these error codes currently missing but should have existed?
There was a problem hiding this comment.
internel error code
e.g. graphd won't send ErrorCode_E_PART_DISABLED code to client
wenhaocs
reviewed
Sep 21, 2024
wenhaocs
reviewed
Sep 21, 2024
|
LGTM. Need more test cases. |
Nicole00
approved these changes
Sep 24, 2024
Nicole00
approved these changes
Sep 24, 2024
|
UT result:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.